Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with paragraph starting with three or more * #1837

Closed
fxha opened this issue Dec 22, 2019 · 0 comments
Closed

Issue with paragraph starting with three or more * #1837

fxha opened this issue Dec 22, 2019 · 0 comments
Labels
🔭 area/muya 🪲 pri/major Bugs will affect your normal use of Mark Text, causing you unwilling or unable to continue using MT 🐛 bug Something isn't working 🦉 pre-release
Projects

Comments

@fxha
Copy link
Contributor

fxha commented Dec 22, 2019

Description

A paragraph starting with *** is correctly interpreted as horizontal rule but if we want to write **bold** by typing two times *, it's still recognized as horizontal rule.

Steps to reproduce

  1. Create a new (empty) paragraph in preview editor.
  2. Write * (--> **) and another * to get **<cursor** - the text block is recognized as horizontal rule (HR) 👍.
  3. Write some text as bold like **foo** - the text block is still recognized as HR 👎.
  4. Press enter or put the cursor into another line and the paragraph is displayed as HR.

Expected behavior:

The line should be a normal paragraph/text.

Actual behavior:

The line is recognized as horizontal rule.

Versions

  • Mark Text: v0.16.0-rc.x (pre-release only)
  • Operating system: all

Hint: I guess that this is an issue that has been created by isAllowedTransformation validation in Muya's paragraphCtrl.js file because we don't allow transformations from horizontal rules due to transformation issues with other markdown elements (multiple crashes in Muya).

@fxha fxha added 🐛 bug Something isn't working 🦉 pre-release 🔭 area/muya 🪲 pri/major Bugs will affect your normal use of Mark Text, causing you unwilling or unable to continue using MT labels Dec 22, 2019
@fxha fxha added this to TO-DO in 0.16.0 Dec 22, 2019
@Jocs Jocs moved this from TO-DO to Review in 0.16.0 Feb 8, 2020
@Jocs Jocs closed this as completed Feb 11, 2020
@Jocs Jocs moved this from Review to Done in 0.16.0 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔭 area/muya 🪲 pri/major Bugs will affect your normal use of Mark Text, causing you unwilling or unable to continue using MT 🐛 bug Something isn't working 🦉 pre-release
Projects
No open projects
0.16.0
  
Done
Development

No branches or pull requests

2 participants