Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions in the image uploader configuration #1848

Closed
5 tasks done
CouldBeThis opened this issue Jan 4, 2020 · 8 comments
Closed
5 tasks done

Add instructions in the image uploader configuration #1848

CouldBeThis opened this issue Jan 4, 2020 · 8 comments
Labels
🐳 help wanted Extra attention is needed

Comments

@CouldBeThis
Copy link
Contributor

Describe your feature request

Preferences -> Image uploader -> GitHub needs a bit of instruction.

I would suggest something like this:

If you don't have a GitHub account, you will need to make one.
A token can be generated in Settings/Developer settings
For more detailed instructions, consult the wiki.
Note: By default, all uploads to GitHub are public. It is possible to configure your repository to be "private".
❓How private is private?? I tried to find some info but can't.

What problem does this feature solve? [optional]

Not everyone is familiar with how to use this GitHub feature. (Or even that GitHub exists.)

Additional context [optional]

Someone else who couldn't figure it out:
How to set github token on mac os ? #1476
It's worth noting that 99% of people who can't figure this out also won't think to make an issue on GH so this is likely an extreme under representation of those with problems.

Also, about the wiki page

This could use a bit of work but I'm not sure what the system is for helping with that. Do I put my edit here or as a new issue? Or if I hit "edit" on the wiki make some magic happen and create a discussion? Or is there someone here really likes editing the wiki?

What's needed is:

  1. Brief 1 or maybe 2 sentence explanation of what GH is.
  2. At least some links to docs about how to create a repo. Hints on what kind to create (public/private, template folder, ghpages... various things that can be confusing.)
  3. A brief description of what a token is
  4. Guidance on what scopes to select. First I tried selecting nothing, but that didn't work. I got it by checking all the boxes in the first section. But are they all required or can/should I change anything? (my repo is private)
  • Repo - Full control of private repositories
    • repo:status - Access commit status
    • repo_deployment - Access deployment status
    • public_repo - Access public repositories
    • repo:invite - Access repository invitations
@CouldBeThis CouldBeThis changed the title bb Add instructions in the image uploader configuration Jan 4, 2020
@Jocs
Copy link
Member

Jocs commented Feb 16, 2020

@CouldBeThis Help is wanted, thanks

@Jocs Jocs added the 🐳 help wanted Extra attention is needed label Feb 16, 2020
@ShravanSunder
Copy link

@CouldBeThis did you get the images to upload. i got the api key and everything setup, according to your comments, but i can't get the image to upload

@mxrodriguez
Copy link

Same issue here. I created the Repo and generated a APi token.. but Image upload is failing.
A bit more details in the wiki would be helpful

@Cipher358
Copy link

Same here on version 0.16.1 of MarkText on a private repository with all the repo permissions.
I tried using a public repo but the result was the same.

@teopost
Copy link

teopost commented Jun 7, 2020

I have the same problem too - rel. 0.16.1

@vio1etus
Copy link

vio1etus commented Oct 8, 2020

same here in Linux. I don't think the instruction is detailed. It‘s the obstacle for me to start using marktext.

@ctjlewis
Copy link

Does anyone know where logs might be located where I can debug why this isn't working? Installed from Flatpak on Ubuntu.

@phanikaran
Copy link

phanikaran commented Mar 12, 2021

This helped me get it done in case someone else's still looking - https://github.com/marktext/marktext/blob/develop/docs/IMAGE_UPLOADER_CONFIGRATION.md

@Jocs Jocs closed this as completed Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐳 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

9 participants