Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings not respected when unsetting multiple shortcuts #2117

Closed
1 task done
HavinLeung opened this issue May 15, 2020 · 0 comments · Fixed by #2130
Closed
1 task done

Keybindings not respected when unsetting multiple shortcuts #2117

HavinLeung opened this issue May 15, 2020 · 0 comments · Fixed by #2130
Assignees
Labels
🐛 bug Something isn't working
Projects

Comments

@HavinLeung
Copy link

Description

keybindings.json not respected if trying to unset multiple shortcuts.

  • Can you reproduce the issue?

Steps to reproduce

  1. Create keybindings.json
  2. Overwrite two id's with "" as accelerator. I used "edit.find-in-folder" and "format.inline-code"
  3. Restart Mark Text

Expected behavior:

The shortcuts should now have no keybinding.

Actual behavior:

both shortcuts have the original keybinding

example:

{
	"edit.find-in-folder": "",
	"format.inline-code": ""
}

current workaround:

{
	"edit.find-in-folder": "",
	"format.inline-code": "F1"
}

Versions

  • Mark Text: v0.16.1
  • Operating system: MacOS 10.15.4
@fxha fxha added the 🐛 bug Something isn't working label May 17, 2020
@fxha fxha self-assigned this May 17, 2020
@fxha fxha added this to In Review in 0.16.2 May 21, 2020
@Jocs Jocs moved this from In Review to Done in 0.16.2 May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants