Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS x64 binary contains arm64 native keytar library #2953

Closed
Duckbilled opened this issue Jan 29, 2022 · 4 comments · Fixed by #2965
Closed

macOS x64 binary contains arm64 native keytar library #2953

Duckbilled opened this issue Jan 29, 2022 · 4 comments · Fixed by #2965
Labels
🐛 bug Something isn't working 🍏 platform/macOS Pull request or issue on macOS 🦉 pre-release 🐞 pri/critical Bugs which cause the Mark Text crash or unable to continue normal use

Comments

@Duckbilled
Copy link

A JavaScript error occured in the main process

Steps to reproduce

  1. Download MarkText (either x64 .dmg or .zip)
  2. open and allow running the application in system preferences
  3. you will receive an error with the message as seen in the screenshots (couldn't copy the text)

Screenshot 2022-01-29 at 20 52 24

Screenshot 2022-01-29 at 20 53 04

Screenshot 2022-01-29 at 20 53 13

Versions

  • MarkText: 0.17.0-rc.1
  • Operating system: MacOS Monterey 12.2
@fxha fxha changed the title A JavaScript error in the main process on MacOS macOS x64 binary contains arm64 native keytar library Jan 29, 2022
@fxha
Copy link
Contributor

fxha commented Jan 29, 2022

Issue: macOS x64 binary contains arm64 native library (keytar).

@Jocs I think I know the problem here. Could you try to yarn remove keytar and yarn add keytar to force update all dependencies and build the binaries with node_modules/.bin/electron-builder build --mac --publish never. This should hopefully download the right prebuilt library, otherwise we would have to disable prebuilt stuff.

@fxha fxha added 🍏 platform/macOS Pull request or issue on macOS 🦉 pre-release 🐛 bug Something isn't working 🐞 pri/critical Bugs which cause the Mark Text crash or unable to continue normal use labels Jan 29, 2022
@Jocs
Copy link
Member

Jocs commented Jan 30, 2022

@fxha I build on macOS with command yarn run release:mac --publish never after yarn remove keytar and yarn add keytar, and it build correctly.

@Jocs
Copy link
Member

Jocs commented Jan 30, 2022

Is it because CI caches keytar? Can we disable keytar caching?

@fxha
Copy link
Contributor

fxha commented Jan 30, 2022

Is it because CI caches keytar? Can we disable keytar caching?

I guess it's because the dependencies from keytar were not correctly updated and the CI worker had to use the version from yarn.lock that may be outdated or bugged. keytar is the only native dependency that download pre-built binaries, but downloaded arm64 for x64 target. I'll create a PR where we regenerate electron-builder too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🍏 platform/macOS Pull request or issue on macOS 🦉 pre-release 🐞 pri/critical Bugs which cause the Mark Text crash or unable to continue normal use
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants