Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste after last line #522

Closed
1 task done
stefnotch opened this issue Oct 25, 2018 · 8 comments
Closed
1 task done

Paste after last line #522

stefnotch opened this issue Oct 25, 2018 · 8 comments
Labels
🐛 bug Something isn't working 🐝 resolved/fixed but not released The bug has been fixed and the new version is not released, So it still opened

Comments

@stefnotch
Copy link
Contributor

Description

Pasting text does not work under certain circumstances.

  • Can you reproduce the issue?

Steps to reproduce

  1. Open Marktext (new file)
  2. Hit Enter (\n) 5 times
  3. Try to paste the following (unformatted) text: Amazing text

Expected behavior:

That the text gets pasted

Actual behavior:

Nothing happens

Versions

  • Mark Text: v 0.13.50
  • Operating system: Windows 10
@fxha
Copy link
Contributor

fxha commented Oct 25, 2018

@stefnotch Does Ctrl+Alt+S (switch to source code mode) work for you on Windows? On my Windows machine it doesn't but on Linux it "just works". There's definitely a huge problem with the keybindings on Linux and Windows but this issue is not affected by that.

@fxha fxha added the 🐛 bug Something isn't working label Oct 25, 2018
@stefnotch
Copy link
Contributor Author

@fxha Ctrl+Alt+S doesn't seem to work for me on Windows.

@fxha
Copy link
Contributor

fxha commented Oct 25, 2018

@stefnotch I guess default German keyboard layout (de-DE)?

@stefnotch
Copy link
Contributor Author

@fxha I tested it with ENG-UK and some custom keyboard layout.

However, this seems to work: https://codepen.io/anon/pen/gBZwwm

@fxha
Copy link
Contributor

fxha commented Oct 25, 2018

I think that the keyboard binding issues are electron issues because I have the same problem on Linux when launching the Windows application with wine. Electron has many open issues regarding this topic. When I have some time I'll hopefully can solve the problem. Maybe handle shortcuts by our self or somehow different...

@stefnotch
Copy link
Contributor Author

@fxha About handling shortcuts in Electron, you could reasonably quickly hack together something with a simple library like:
https://www.npmjs.com/package/mousetrap
https://github.com/matthewshirley/node-iohook
https://github.com/matthewshirley/node-mousetrap

@Jocs Jocs closed this as completed in f0c691e Oct 25, 2018
@Jocs Jocs added the 🐝 resolved/fixed but not released The bug has been fixed and the new version is not released, So it still opened label Oct 25, 2018
@Jocs
Copy link
Member

Jocs commented Oct 25, 2018

@stefnotch Thanks, the has issue has been fixed, we'll release a hotfix version these days.

@fxha
Copy link
Contributor

fxha commented Oct 25, 2018

About handling shortcuts in Electron, you could reasonably quickly hack together something with a simple library like

Yes, I'll definitive take a look at these resources.

As regards the Ctrl+Alt+S issue, it's a electron v3 bug. I can reproduce it with a simple application on Windows and I'll report it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🐝 resolved/fixed but not released The bug has been fixed and the new version is not released, So it still opened
Projects
None yet
Development

No branches or pull requests

3 participants