Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Electron's simple fullscreen mode #536

Open
kibiz0r opened this issue Oct 31, 2018 · 3 comments
Open

Support Electron's simple fullscreen mode #536

kibiz0r opened this issue Oct 31, 2018 · 3 comments
Assignees
Labels
🍏 platform/macOS Pull request or issue on macOS

Comments

@kibiz0r
Copy link

kibiz0r commented Oct 31, 2018

Describe your feature request

I like using fullscreen (no menu bar) apps, but I dislike using macOS's spaces feature.

Since Electron now has a simple fullscreen mode, I'd love to use that in Mark Text.

What problem does this feature solve? [optional]

macOS spaces suck, but fullscreen rocks. 😄

Additional context [optional]

Electron simple fullscreen PR: electron/electron#10254

I guess I'm asking just because VSCode now finally supports it, so why not all Electron apps!

@fxha fxha added the 🍏 platform/macOS Pull request or issue on macOS label Oct 31, 2018
@Jocs
Copy link
Member

Jocs commented Nov 7, 2018

I guess I'm asking just because VSCode now finally supports it

How to enable VSCode fullscreen mode ?

@kibiz0r
Copy link
Author

kibiz0r commented Nov 11, 2018

I think it's only in the Insiders version of VSCode for now, but it's called "Simple Fullscreen" or simpleFullscreen.

I have been seeing some weird issues with it though, so I'm actually not sure it's ready. It depends if the problems I'm seeing are from Electron or VSCode. microsoft/vscode#5344 (comment)

@kibiz0r
Copy link
Author

kibiz0r commented Nov 21, 2018

Looks like others are seeing issues with Electron's fullscreen mode, too, so it might be a while before you can even start on this. microsoft/vscode#5344 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍏 platform/macOS Pull request or issue on macOS
Projects
None yet
Development

No branches or pull requests

3 participants