Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not load image when the extension in the url is missing #79

Closed
leaves4j opened this issue Mar 26, 2018 · 5 comments
Closed

Can not load image when the extension in the url is missing #79

leaves4j opened this issue Mar 26, 2018 · 5 comments
Assignees
@fxha
Labels
🐛 bug Something isn't working 🐝 resolved/fixed but not released The bug has been fixed and the new version is not released, So it still opened 🐳 help wanted Extra attention is needed
Projects
version 0.11.25

Comments

@leaves4j
Copy link

Description

Support using SVG as an image

Steps to reproduce

![svg_image](svg_url) not work

Versions

  • Mark Text: 0.7.17
  • OS: macOS 10.13.3
@Jocs Jocs added the 🐛 bug Something isn't working label Mar 26, 2018
@Jocs
Copy link
Member

Jocs commented Mar 26, 2018 •
edited

I just test weather Mark Text support SVG image, I found that the SVG image is OK.
1522069937807

Can you give me a failed SVG url? So I can test it.

@Jocs Jocs added the 🐤 blocked/need info Need more details about this issue or pull request label Mar 26, 2018
@leaves4j
Copy link
Author

svg url: http://www.plantuml.com/plantuml/svg/SyfFqhLppCbCJbMmKiX8pSd91m00

@SuperSandro2000
Copy link
Contributor

This misses the svg ending

@leaves4j
Copy link
Author

We can determine the type by Content-Type

@Jocs
Copy link
Member

Jocs commented Mar 30, 2018

@leaves4j In order to get a high performance when you are writing a image src. Mark Text does not ask a request before it find a image url.(ends with .svg, .png etc)

@Jocs Jocs added 🐳 help wanted Extra attention is needed and removed 🐤 blocked/need info Need more details about this issue or pull request labels Mar 30, 2018
@Jocs Jocs changed the title Support using SVG as an image Load image when the extension in the url is missing Mar 31, 2018
@Jocs Jocs changed the title Load image when the extension in the url is missing Can not load image when the extension in the url is missing Mar 31, 2018
@Jocs Jocs added this to To Do in version 0.11.25 Apr 16, 2018
@fxha fxha mentioned this issue Apr 26, 2018
Merged
@Jocs Jocs moved this from To Do to In Progress in version 0.11.25 May 20, 2018
@Jocs Jocs moved this from In Progress to Done in version 0.11.25 May 28, 2018
@Jocs Jocs added the 🐝 resolved/fixed but not released The bug has been fixed and the new version is not released, So it still opened label May 28, 2018
@Jocs Jocs closed this as completed May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxha fxha

Labels
🐛 bug Something isn't working 🐝 resolved/fixed but not released The bug has been fixed and the new version is not released, So it still opened 🐳 help wanted Extra attention is needed
Projects
No open projects
version 0.11.25
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@leaves4j @SuperSandro2000 @Jocs @fxha