Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fail-fast false strategy on multi environment test #106

Merged
merged 1 commit into from Nov 2, 2020
Merged

use fail-fast false strategy on multi environment test #106

merged 1 commit into from Nov 2, 2020

Conversation

conao3
Copy link
Collaborator

@conao3 conao3 commented Oct 27, 2020

use fail-fast false strategy on multi environment test
This PR fixes situation mentioned #105 (comment)

@coveralls
Copy link

coveralls commented Oct 27, 2020 •
edited

Pull Request Test Coverage Report for Build 627

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.099%
Totals Coverage Status
Change from base Build 625: 0.0%
Covered Lines: 2316
Relevant Lines: 3156
💛 - Coveralls

@YusukeHirao
Copy link
Member

@conao3 Thanks!

@tyankatsu0105 Could you review this PR?

@tyankatsu0105
Copy link
Collaborator

Sure.

tyankatsu0105
tyankatsu0105 approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@tyankatsu0105 tyankatsu0105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about this option but looks good.

@YusukeHirao
Copy link
Member

@tyankatsu0105 Thanks!

@YusukeHirao YusukeHirao merged commit 57dfea1 into markuplint:master Nov 2, 2020
@conao3
Copy link
Collaborator Author

conao3 commented Nov 3, 2020

Thanks for merging!

@conao3 conao3 deleted the fix-actions-conf branch November 3, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyankatsu0105 tyankatsu0105 tyankatsu0105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@conao3 @coveralls @YusukeHirao @tyankatsu0105