Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path about drive letter for Windows #1526

Conversation

okathira
Copy link
Contributor

Fixes #1518

What is the purpose of this PR?

  • Fix bug
  • Fix typo
  • Update specs
  • Add new rule
  • Add new parser
  • Improve or refactor rules
  • Add a new core feature
  • Improve or refactor core features
  • Update documents
  • Others

Description

Make the extension work regardless of which drive the open location is on.

Excuse me, still I have yet to check the extension in real action. Is there way to do it on Windows?

Checklist

Fill out the checks for the applicable purpose.

@YusukeHirao
Copy link
Member

@okathira

Thank you for your contribution!
It seems that the CI tests are failing.
Could you please make the necessary adjustments to your pull request?

@okathira
Copy link
Contributor Author

okathira commented Mar 11, 2024

@YusukeHirao
I checked CI on the current dev branch, I have the same results.
So what should I do?
checked CI: https://github.com/okathira/markuplint/pull/2/checks
(I dont have checked details of the results yet...)

@okathira
Copy link
Contributor Author

I created another issue about the CI tests failing #1534

@YusukeHirao
Copy link
Member

@okathira
Please merge the latest dev branch. The tests will likely run successfully.

@okathira okathira force-pushed the fix/extension-config-error-depending-on-the-drive-on-windows branch from fbb5663 to 6881015 Compare March 25, 2024 13:12
@okathira
Copy link
Contributor Author

@YusukeHirao
I rebased and force pushed. Please run the tests.

@YusukeHirao YusukeHirao merged commit 96fcb00 into markuplint:dev Mar 25, 2024
31 checks passed
@YusukeHirao
Copy link
Member

@okathira Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix config-error when project is located non-default drive on Windows
2 participants