Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check pawn entity health #442

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Conversation

BestAwperEver
Copy link
Contributor

It looks like in the past 12 hours almost every cs2 demo from Faceit (maybe even every single one, I'm not sure about that) crashes with panic: interface conversion: interface {} is nil, not uint64 because of Any field of the m_iPawnHealth property of any player controller entity always being nil, so I'm proposing this as a hotfix.

Example match: https://www.faceit.com/en/cs2/room/1-f0438560-e84a-451b-b5f4-572917e9ad32

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4d9f95a) 80.18% compared to head (917bf35) 80.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   80.18%   80.15%   -0.04%     
==========================================
  Files          47       47              
  Lines        6197     6197              
==========================================
- Hits         4969     4967       -2     
- Misses       1019     1022       +3     
+ Partials      209      208       -1     
Files Coverage Δ
pkg/demoinfocs/common/player.go 63.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akiver
Copy link
Collaborator

akiver commented Oct 13, 2023

Thank you!
Armor is also affected, could you please change it to return getInt(p.PlayerPawnEntity(), "m_ArmorValue")?

My bad, it has been changed recently in #438

Thanks

BestAwperEver and others added 2 commits October 15, 2023 10:41
Co-authored-by: AkiVer <ys.renaud@gmail.com>
@akiver akiver merged commit 2c9b7f9 into markus-wa:master Oct 15, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants