Add shouldBeInRange for ClosedRanges #119 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add JVM support for backtick version
|
Thank you for the contribution! |
Signed-off-by: Kshitij09 <kshitijpatil98@gmail.com>
1 task
Resolved merge conflicts with javatarz/range-assertions branch. Added Unit tests for shouldNotBeInRange. Also made appropriate method call for backtick version. Added name into AUTHORS file. Signed-off-by: Kshitij09 <kshitijpatil98@gmail.com>
Fix the link to Kshitij09's commits
Added shouldNotBeInRange for ClosedRange MarkusAmshove#119
|
Hey @MarkusAmshove, @Kshitij09 has helped me out in implementing Can you have a look at this PR before merging? |
|
Thank you, I've merged it and put it onto my todo list for 1.60. |
|
This is now part of v1.60 |
MarkusAmshove
added a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completes open issue #119 by implementing
ClosedRange<T>.shouldBeInRange(ClosedRange<T>).Also adds JVM support for backtick version.
Already a contributor so no addition to the
AUTHORSfile :)Checklist
AUTHORSfile, if it wasn't already present.