Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash/LED button not doing anything #401

Open
sukulent opened this issue Oct 27, 2023 · 7 comments
Open

Flash/LED button not doing anything #401

sukulent opened this issue Oct 27, 2023 · 7 comments

Comments

@sukulent
Copy link

Firstly, thanks for this app, I have tried many code readers but this one feels the best. Easy, clean, FOSS.

Just the flash button doesn't do anything. Which is kinda breaking as lighting is important when scanning.

I have motorola moto G54 power edition running android 13 and BinaryEye version 1.61.0

also the vibration do not work, but I guess that's fine
(tho maybe it could point somewhere?)

@sukulent
Copy link
Author

Oops seems like I made a duplicate of #234 and #300 .

But sadly, the issue is still here, I have not bumped into this problem in any other app.
is there any debugging I could do to help?

@markusfisch
Copy link
Owner

Thanks for reporting this anyway! It's still a mystery to me, unfortunately, as I was never able to reproduce this, and the code is pretty straight forward 🙈

So, to fix this, I would need to know what is going wrong, especially what parameters.flashMode is here, and if there is an exception here. In which case you should see a message.

@sukulent
Copy link
Author

sukulent commented Nov 3, 2023

I want to make one app someday and I found a bit of time, so I have cloned the repo and dipped my fingers into android studio debugger. So when I run debug, it installs it onto my phone and:

after tapping the flash button
parameters.flashMode = "off"
then it assigns "torch" to it so
parameters.flashMode = "torch"
then it successfully assigns the parameters to camera.parameters without exception
when I put into the debugger camera.parameters.flashMode it says it's "torch"
and the function returns with no flash what so ever 👀

@markusfisch
Copy link
Owner

Thanks a lot anyway! 👍

This is nevertheless helpful as it rules out obvious reasons! Still very strange, of course 🤔 Hm.

@samthelion17
Copy link

Also, the flashlight button gets greyed out while BinaryEye is open.
Screenshot_2023-12-01-22-52-34-263
I know you haven't been able to replicate the issue but I hope that every small detail we can provide gets you closer to fixing this bug. In the end BinaryEye will continue to be my only barcode/qr scanner, so far I don't need to scan codes in absolute darkness.

@sukulent
Copy link
Author

sukulent commented Dec 9, 2023

@samthelion17 that is a feature of android, when something opens the camera through the api (aka the way the system makes hw available to apps), the flashlight is 'glued' to that, so you can't use that button, if I'm saying that right

@Efenstor
Copy link

Efenstor commented Feb 26, 2024

It does not work for me too. I am using LineageOS GSI (TrebleDroid-based). It works fine in the other apps, Open Camera (by Mark Harman) for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants