Fix calling TimeZone::createFromPhpDateTimeZone with default values #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value for the begin date created a date B.C. which could not be parsed. Therefore the new default value was set to the year of Christ birth. The daylight saving time was introduced in 1916, therefore any begin date before that year will not produce further output. Calling TimeZone::createFromPhpDateTimeZone with default values will now trigger a (silenced) deprecation error. Fixes #240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for the begin date created a date B.C. which could not be parsed.
Therefore the new default value was set to the year of Christ birth.
The daylight saving time was introduced in 1916, therefore any begin date before that year will not produce further output.
Calling TimeZone::createFromPhpDateTimeZone with default values will now trigger a (silenced) deprecation error.
Fixes #240