Add support for DateTimeImmutable in buildPropertyBag #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `dtEnd` were to be a DateTimeImmutable instead of a DateTime, the add method would have no effect on the outcome. Here, we update the stored dtEnd with the result of the add method. For a DateTime object, this will be the same object - for a DateTimeImmutable object, this will be a new DateTimeImmutable one day in the future.
|
I tried to update your branch but for some reasons the Pull Request did not update. Therefore I will push to master directly. I added a test and the changes explained above. |
|
Ok. Something went wrong either with my computer or with GitHub. I can swear my commit was missing. xD Merged to master. @navarr Thanks for your Pull Request! 👍 |
|
Available in Version 0.12.1 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
dtEndwere to be a DateTimeImmutable instead of a DateTime, the add method would have no effect on the outcome.Here, we update the stored dtEnd with the result of the add method. For a DateTime object, this will be the same object - for a DateTimeImmutable object, this will be a new DateTimeImmutable one day in the future.