Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only delete folders that are empty due to image removal #1

Closed
markusressel opened this issue Apr 11, 2019 · 0 comments · Fixed by #10
Closed

Only delete folders that are empty due to image removal #1

markusressel opened this issue Apr 11, 2019 · 0 comments · Fixed by #10
Assignees
@markusressel
Labels
enhancement New feature or request

Comments

@markusressel
Copy link
Owner

markusressel commented Apr 11, 2019 •
edited
Loading

Currently the "remove empty folders" phase does not take into account which image files were removed. It simply scans for empty folders and removes them. This can be a problem for hidden folders like.stfolder that should never be deleted or folders that were purposely created beforehand by the user.

To improve that, this phase should only delete folders that are empty because all of the files that were in it were removed by the deduplication process (aka at least one file was removed from a given directory).
@markusressel markusressel added the enhancement New feature or request label Apr 11, 2019
@markusressel markusressel self-assigned this Apr 11, 2019
Repository owner deleted a comment from welcome bot Apr 11, 2019
@markusressel markusressel mentioned this issue Sep 2, 2019
Merged
markusressel added a commit that referenced this issue Sep 2, 2019
@markusressel
Merge pull request #10 from markusressel/feature/#1_remove_folders_on…
f754bc9 
…ly_if_empty_due_to_deduplication

Feature/#1 remove folders only if empty due to deduplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markusressel markusressel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#1 remove folders only if empty due to deduplication markusressel/py-image-dedup
1 participant
@markusressel