Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: tempo editing in the MiscWidget #19

Merged

Commits on Aug 30, 2019

  1. Configuration menu
    Copy the full SHA
    5dada67 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Configuration menu
    Copy the full SHA
    e6ffc64 View commit details
    Browse the repository at this point in the history
  2. update docs

    daslomin-microsoft committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    4ac3f07 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. necessary but not sufficient: disallow a tempo of zero

    Div Slomin committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    92721b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. "interpolate" now extrapolates too, which seems to fix it for real

    The two pass approach didn't help, and made lines which were drawn straight
    actually appear curved when you released the mouse.  The problem actually
    appeared to be coming from needing to handle points a little beyond the end of
    the "toAlign" array, so I had to make the interpolate function extrapolate off
    the right end of that line.  Also fixed a problem with inserting lots of
    "minimum possible value" events if the user released the mouse below the bottom
    edge of the window.
    daslomin-microsoft committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    5252f84 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. now properly working for adding events, but still not removing old on…

    …es correctly
    
    In particular, I still need to figure out what the righthand bound of the range
    should be for removing the old events.  maxTick isn't correct, even if you
    recompute it as xPosToTock(toAlign.last().first) each time you go around the
    loop, because the end point depends on the tempo events you're going to insert
    not the ones which are already there.  I may need to intersperse the remove and
    add rather than having them in separate loops.
    daslomin-microsoft committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    62fe13b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. now the time range of adds and deletes is accurate in all cases

    What you draw is evaluated in the context of what's already there, so that
    means that a tempo line which you draw straight will end up curved once you
    release the mouse.  That's unintuitive, but I'm starting to think it's not
    actually a bug, just an accurate reflection of what the straight line really
    means.
    daslomin-microsoft committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    15a501f View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Configuration menu
    Copy the full SHA
    a45c40e View commit details
    Browse the repository at this point in the history