New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: tempo editing in the MiscWidget #19
Merged
markusschwenk
merged 8 commits into
markusschwenk:master
from
dgslomin:feature/misc-widget-tempo-editor
Oct 20, 2019
Merged
Feature: tempo editing in the MiscWidget #19
markusschwenk
merged 8 commits into
markusschwenk:master
from
dgslomin:feature/misc-widget-tempo-editor
Oct 20, 2019
Commits on Aug 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5dada67 - Browse repository at this point
Copy the full SHA 5dada67View commit details
Commits on Sep 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e6ffc64 - Browse repository at this point
Copy the full SHA e6ffc64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ac3f07 - Browse repository at this point
Copy the full SHA 4ac3f07View commit details
Commits on Sep 16, 2019
-
necessary but not sufficient: disallow a tempo of zero
Div Slomin committedSep 16, 2019 Configuration menu - View commit details
-
Copy full SHA for 92721b4 - Browse repository at this point
Copy the full SHA 92721b4View commit details
Commits on Sep 18, 2019
-
"interpolate" now extrapolates too, which seems to fix it for real
The two pass approach didn't help, and made lines which were drawn straight actually appear curved when you released the mouse. The problem actually appeared to be coming from needing to handle points a little beyond the end of the "toAlign" array, so I had to make the interpolate function extrapolate off the right end of that line. Also fixed a problem with inserting lots of "minimum possible value" events if the user released the mouse below the bottom edge of the window.
Configuration menu - View commit details
-
Copy full SHA for 5252f84 - Browse repository at this point
Copy the full SHA 5252f84View commit details
Commits on Sep 19, 2019
-
now properly working for adding events, but still not removing old on…
…es correctly In particular, I still need to figure out what the righthand bound of the range should be for removing the old events. maxTick isn't correct, even if you recompute it as xPosToTock(toAlign.last().first) each time you go around the loop, because the end point depends on the tempo events you're going to insert not the ones which are already there. I may need to intersperse the remove and add rather than having them in separate loops.
Configuration menu - View commit details
-
Copy full SHA for 62fe13b - Browse repository at this point
Copy the full SHA 62fe13bView commit details
Commits on Sep 20, 2019
-
now the time range of adds and deletes is accurate in all cases
What you draw is evaluated in the context of what's already there, so that means that a tempo line which you draw straight will end up curved once you release the mouse. That's unintuitive, but I'm starting to think it's not actually a bug, just an accurate reflection of what the straight line really means.
Configuration menu - View commit details
-
Copy full SHA for 15a501f - Browse repository at this point
Copy the full SHA 15a501fView commit details
Commits on Sep 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a45c40e - Browse repository at this point
Copy the full SHA a45c40eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.