init commit of edits for exposing C api #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Hmm can't merge because of a failing test (I'm on my phone now). |
|
Hmm, all Travis tests passed, I think it's just that test coverage dropped by 0.2%. I think the drop is due to the |
|
I just merged it. There was no real fail but a minor drop in the test coverage (naturally). Apparently it is not possible to merge from the phone when that happens. In any case I'm back in town and I'm able to respond much quicker. I'll have a good look at WRE on the C API this week. Looking forward to getting this out there! |
|
馃憤 Sounds great! Yeah I think the coverage drop was the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #67. As mentioned before, I created this branch just to get the ball rolling on the API, so am happy to make edits (or if it needs to be torn down and redone, that's cool too 馃槃 ).