do removeView in onCreate to ensure double check

markzhai · Sep 1, 2016 · e896e65 · e896e65
1 parent c1a3def
commit e896e65
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -37,7 +37,7 @@ sh package.sh
 
 ```groovy
 dependencies {
-    compile "com.github.moduth:react-native-preloader:0.31.0"
+    compile "com.github.markzhai:react-native-preloader:0.32.0"
 }
 ```
 

diff --git a/preloader/gradle.properties b/preloader/gradle.properties
@@ -1,9 +1,9 @@
 POM_NAME=React Native Pre-loader
 POM_ARTIFACT_ID=react-native-preloader
 POM_PACKAGING=aar
-VERSION_NAME=0.31.0
-VERSION_CODE=1
-GROUP=com.github.moduth
+VERSION_NAME=0.32.0
+VERSION_CODE=2
+GROUP=com.github.markzhai
 
 POM_DESCRIPTION=React Native Pre-loader for Android
 POM_URL=https://github.com/markzhai/react-native-preloader

diff --git a/preloader/src/main/java/com/github/markzhai/react/preloader/MrReactActivity.java b/preloader/src/main/java/com/github/markzhai/react/preloader/MrReactActivity.java
@@ -24,6 +24,7 @@
 import android.provider.Settings;
 import android.util.Log;
 import android.view.KeyEvent;
+import android.view.ViewGroup;
 import android.widget.Toast;
 
 import com.facebook.common.logging.FLog;
@@ -133,6 +134,14 @@ protected void onCreate(Bundle savedInstanceState) {
             Log.i(TAG, "use pre-load view");
             MutableContextWrapper contextWrapper = (MutableContextWrapper) mReactRootView.getContext();
             contextWrapper.setBaseContext(this);
+            try {
+                ViewGroup viewGroup = (ViewGroup) mReactRootView.getParent();
+                if (viewGroup != null) {
+                    viewGroup.removeView(mReactRootView);
+                }
+            } catch (Exception exception) {
+                Log.e(TAG, "getParent error", exception);
+            }
         } else {
             Log.i(TAG, "createRootView");
             mReactRootView = createRootView();