Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR] annotation sampler #173

Merged
merged 3 commits into from Sep 28, 2017
Merged

[CR] annotation sampler #173

merged 3 commits into from Sep 28, 2017

Conversation

bmcfee
Copy link
Contributor

@bmcfee bmcfee commented Sep 9, 2017

This PR implements #109

@bmcfee bmcfee added this to the 0.3.1 milestone Sep 9, 2017
@bmcfee bmcfee self-assigned this Sep 9, 2017
@bmcfee bmcfee changed the title [WIP] annotation sampler [CR] annotation sampler Sep 19, 2017
@bmcfee
Copy link
Contributor Author

bmcfee commented Sep 19, 2017

This one's ready for CR, @rabitt or @justinsalamon want to chime in?

The scope of the PR is just implementing value sampling for a set of specified time instants. It does not implement any automatic time gridding. This decision is mainly because the duration field is optional for an annotation, so samples generated from multiple annotations for the same track might not be easy to align. What are yalls thoughts on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant