Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build_array function consider requested output file_type #132

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dmitriilazukov
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Feb 9, 2021

Coverage Status

Coverage increased (+0.003%) to 98.825% when pulling ff51fc0 on dmitriilazukov:make-build-array-consider-file-type into 0a428b8 on rabitt:master.

@lostanlen
Copy link
Member

lostanlen commented Feb 10, 2021

Thanks. Could you write a unit test for this?
How does this affect the behavior of pysox? Is it backwards compatible?

@dmitriilazukov
Copy link
Author

dmitriilazukov commented Feb 17, 2021

Hi!

Could you write a unit test for this?

Done.

How does this affect the behavior of pysox?

Now build_array function works correctly. It used to ignore output file_type parameter and generate only "raw" type. Now it uses given file_type if supplied.

Is it backwards compatible?

I believe so. I did not change any core logic.

@dmitriilazukov
Copy link
Author

@lostanlen Hi, did you have a chance to review changes?

@lostanlen
Copy link
Member

Thanks @dmitriilazukov. LGTM

@lostanlen
Copy link
Member

@rabitt this is ready for merging IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants