Implement zigup default master
#34
Conversation
|
I have also rebased it to master |
| } else { | ||
| try setDefaultCompiler(allocator, compiler_dir, .verify_existence); | ||
| } | ||
| try setDefaultCompiler(allocator, compiler_dir, .verify_existence); |
There was a problem hiding this comment.
I don't think this will work on windows since it doesn't have symlinks (not sure why github actions isn't testing your PR). I'm fairly certain that what needs to be done is when we see "master", we need to resolve the master version (if master has not been downloaded print a nice error that it hasn't been fetched), and then call setDefaultCompiler with that specific version.
There was a problem hiding this comment.
Also we should test the case where we run zigup deafult master before we have downloaded anything and verify we get a good error message.
If you want me to finish the PR I can but I'll give you a change to implement it if you like.
There was a problem hiding this comment.
Oh alright. I don't have a windows PC so I couldn't test it and thus I cannot reliably implement it either. So yeah please continue.
|
Ok I finished the implementation and added a test to make sure that we get a good error when master is not fetched. I'll give you a change to review the code before merging. |
|
Ohh it makes sense now, looks good |
It just removes the explicit check as missing of
mastersymlink would already get detected by setDefaultCompiler().Implements as per discussed on discord/issue topic.
I noticed that you aren't doing zig fmt, so I didn't did it either.
Closes #33