Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typing and add additional docs #16

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix: typing and add additional docs #16

merged 1 commit into from
Jun 12, 2023

Conversation

JosefBredereck
Copy link
Contributor

Since in the docs it is stated that

| sizes* | ImageSize[] | (required) - Specify the sizes to which the uploaded image should be

it should be reflected in the type definition.

Also added information about type safety in plugins.ts

@marlokessler marlokessler added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 12, 2023
@marlokessler marlokessler merged commit 05efb37 into marlokessler:main Jun 12, 2023
@marlokessler
Copy link
Owner

@all-contributors please add @JosefBredereck for code and doc.

@allcontributors allcontributors bot mentioned this pull request Jun 12, 2023
Merged
@allcontributors
Copy link
Contributor

@marlokessler

I've put up a pull request to add @JosefBredereck! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlokessler marlokessler marlokessler approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JosefBredereck @marlokessler