Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to queue up slow commands #279

Closed
tomKPZ opened this issue May 31, 2021 · 5 comments
Closed

Unable to queue up slow commands #279

tomKPZ opened this issue May 31, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@tomKPZ
Copy link

tomKPZ commented May 31, 2021

  • zsh-autocomplete version: 7f44a6d
  • Zsh version: zsh-5.8-436-g0c14732
  • Framework: Oh My Zsh
$ cd ~zsh-autocomplete
$ git switch main       # Make sure you test with the `main` branch.
$ git pull              # Update to the latest commit.
$ cd $(mktemp -d)       # Create a temp dir and enter it.
$ # Restart Zsh without config files or environment variables in this dir:
$ exec env -i HOME=$PWD PS1='%# ' TERM=$TERM zsh -f
% source /path/to/zsh-autocomplete/zsh-autocomplete.plugin.zsh
% # Type the following rapidly: "sleep 1<Enter>ls<Enter>"

The ls command gets lost if it is typed while sleep 1 is running. Queueing up slow commands is useful when working with large repositories and it seems to work in all major shells (bash, zsh, fish). The issue only reproduces when zsh-autocomplete is enabled.

@tomKPZ tomKPZ added the bug Something isn't working label May 31, 2021
@marlonrichert marlonrichert self-assigned this Jun 1, 2021
marlonrichert added a commit that referenced this issue Jun 1, 2021
@marlonrichert
Copy link
Owner

Fixed.

@tomKPZ
Copy link
Author

tomKPZ commented Jun 1, 2021

Thanks for the fix! However there seems to be a lingering issue. With the patch, if I type sleep 1<Enter>ls<Enter> then I see ls<Newline>, but I still have to press Enter to run the command. The command should be run without additional input.

@marlonrichert
Copy link
Owner

Hm, I didn't realize it behaved like that. I'll look into it.

@marlonrichert marlonrichert reopened this Jun 1, 2021
marlonrichert added a commit that referenced this issue Jun 1, 2021
@marlonrichert
Copy link
Owner

Well, that was quite easy.

@tomKPZ
Copy link
Author

tomKPZ commented Jun 1, 2021

Wow that was fast! I can confirm it's working properly now, thanks again!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants