Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override ↑ and ↓ bindings when fzf is installed #59

Closed
paw-lu opened this issue Jun 16, 2020 · 4 comments
Closed

Don't override ↑ and ↓ bindings when fzf is installed #59

paw-lu opened this issue Jun 16, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@paw-lu
Copy link

paw-lu commented Jun 16, 2020

Is your feature request related to a problem? Please describe.

Currently, if fzf is installed, zsh-autocomplete will rebind so that it no longer toggles through history, but fuzzy searches through it.

For my usage this seems unnecessary, since ^+R already activates fuzzy search, and is a convenient well-known shortcut to repeat the last few commands.

Describe the solution you'd like

Either disable the automatic remapping of when fzf is detected or offer an option to bring it back to its original functionality.


Again, thanks for the great work!

@paw-lu paw-lu added the enhancement New feature or request label Jun 16, 2020
@yutkat
Copy link

yutkat commented Jun 17, 2020

I agree with you.

this is the workaround.

function precmd_remove_up_down_bindkey() {
  bindkey '^[OA' up-line-or-history
  bindkey '^[OB' down-line-or-history
}

autoload -Uz add-zsh-hook
add-zsh-hook precmd precmd_remove_up_down_bindkey

@marlonrichert marlonrichert changed the title Don't hijack native ↑ and ↓ functionality when fzf is installed Don't override ↑ and ↓ bindings when fzf is installed Jun 18, 2020
@dylanjm
Copy link

dylanjm commented Jun 25, 2020

Another comment would be to suppress completions when using up-line-or-history. When I move back in history and am modifying commands, it would be good to hold off on showing completions until I start typing or something.

@marlonrichert
Copy link
Owner

@dylanjm I actually have implemented that already in my local copy of the dev branch. You can expect to see it soon.

marlonrichert added a commit that referenced this issue Jun 26, 2020
* Address issue #51.
* Improve `menu-select` logic.
* Add a setting to disabled `fzf` integration. Address issue #59.
@marlonrichert
Copy link
Owner

Merged to master.

marlonrichert added a commit that referenced this issue Jun 26, 2020
* Address issue #51.
* Improve `menu-select` logic.
* Add a setting to disable `fzf` integration. Address issue #59.
marlonrichert added a commit that referenced this issue Jun 26, 2020
* Address issue #51.
* Improve `menu-select` logic.
* Add a setting to disable `fzf` integration. Address issue #59.
yutkat added a commit to yutkat/dotfiles that referenced this issue Jun 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants