Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable suggestions for aliases #60

Closed
benwoodward opened this issue Jun 17, 2020 · 4 comments
Closed

Enable suggestions for aliases #60

benwoodward opened this issue Jun 17, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@benwoodward
Copy link

Is your feature request related to a problem?

Typing git c will yield a long list of git commands starting with 'c':

image

However, when invoking git via g alias (alias g='git') does not yield git-related results:
image

Describe the solution you'd like

Ideally I'd like the plugin to automatically detect that an alias is being used, and look up the relevant results.

@benwoodward benwoodward added the enhancement New feature or request label Jun 17, 2020
marlonrichert added a commit that referenced this issue Jun 17, 2020
@marlonrichert
Copy link
Owner

marlonrichert commented Jun 17, 2020

@benwoodward It's virtually impossible for me to figure out which of a user's aliases should map to which commands, since aliases can include multiple commands and all other kinds of nonsense. However, what I can do is automatically expand aliases. So, for example, in your case, if you type g plus space, then it will automatically expand to git , which will then result in Zsh offering the correct completions. This feature is now available on the dev branch. Please try it out.

@marlonrichert
Copy link
Owner

marlonrichert commented Jun 25, 2020

I just discovered that the COMPLETE_ALIASES option did not do what I thought it did. Unsetting it turns out to be enough to get this to work.

marlonrichert added a commit that referenced this issue Jun 26, 2020
@marlonrichert
Copy link
Owner

Fixed in master.

marlonrichert added a commit that referenced this issue Jun 26, 2020
@benwoodward
Copy link
Author

Hell yeah! Nice work! Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants