Fix error when global isFinite is undefined
#10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I'll take a closer look during the weekend. |
|
@marlun78 Any progress on this PR? This fix allows me to use this package in IE which unfortunately is a requirement for me. Thanks! |
|
Sorry guys, I've been super busy lately. I'll do it during the weekend. |
|
I chose a slightly different implementation, but thanks for the PR. |
|
@jeremiahrhall @chris-garrett Please let me know if this didn’t solve your issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I ran into an issue using this package with PhantomJS. Apparently,
isFiniteis not defined in the global scope or onNumberin PhantomJS so, this change just defines a simple polyfill for that case.