Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora 23 updates #1

Closed
wants to merge 6 commits into from
Closed

Fedora 23 updates #1

wants to merge 6 commits into from

Conversation

m-v-b
Copy link

@m-v-b m-v-b commented Apr 11, 2016

Please consider this as an interim pull request, mainly for gathering reviews, as there is a commit which disables the KDE default setting customizations, which I should have rebased to the top and labeled '[do-not-merge]'.


%global build_kde4 1

Name: plasma-breeze
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name the package differently (plasma-breeze-qubes?), then add appropriate dependencies like Conflicts: plasma-breeze, or even Provides: plasma-breeze. If possible, that would be better than setting epoch, which is really hard to rollback in the future if needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am taking the suggested approach. I added both of Conflicts and Provides for the main package and the sub-packages; I hope this (Conflicts + Provides) is fine.

If the epoch is not unconditionally defined, then yum-builddeps reports
errors.
This commit is not complete, as it completely ignores the KDE
customizations implemented for Qubes OS.
…kages

... temporarily, as these packages cause transaction errors
at installation time.
@m-v-b
Copy link
Author

m-v-b commented Apr 24, 2016

Thank you for the review, and sorry for the delay in responding. I am currently testing a number of changes (including a few that address the comments for this pull request). I hope to publish what I have this evening.

@marmarek
Copy link
Owner

marmarek commented May 4, 2016

I've pushed fedora-23 branch to my repo. It contains your changes (without those 'DO-NOT-MERGE'), together with some preliminary update of other packages (kde-settings, kde-baseapps etc).
Customization not migrated yet:

  • set default wallpaper
  • set menu button icon
  • disable user switch feature
  • set breeze theme by default
  • remove "Places" section from "Computer" tab in the menu (or "Computer" tab at all)
  • remove device notifier applet

@m-v-b
Copy link
Author

m-v-b commented May 7, 2016

Sounds good -- thank you for merging the Breeze theme-related commits!

@m-v-b m-v-b closed this May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants