[RFR] Default export

CHANGELOG

@@ -1,6 +1,12 @@
 # CHANGELOG
 
-### 1.1.0
+### 1.1.x
+
+**1.1.1:**
+
+[#233](https://github.com/marmelab/EventDrops/pull/233): fix default export for users without module bundler
+
+**1.1.0:**
 
 [#232](https://github.com/marmelab/EventDrops/pull/232): minor README fixes
 [#231](https://github.com/marmelab/EventDrops/pull/231): allow to display chart from end to start

src/index.js

@@ -8,15 +8,9 @@ import zoom from './zoom';
 import { addMetaballsDefs } from './metaballs';
 
 import './style.css';
+import { withinRange } from './withinRange';
 
-export const withinRange = (date, dateBounds) => {
-    const startingDate = Math.min(...dateBounds);
-    const endingDate = Math.max(...dateBounds);
-
-    // @TODO: remove the `new Date()` constructor in the next major version: we need to force it at configuration level.
-    return new Date(date) >= startingDate && new Date(date) <= endingDate;
-};
-
+// do not export anything else here to keep window.eventDrops as a function
 export default ({ d3 = window.d3, ...customConfiguration }) => {
     const chart = selection => {
         const config = defaultsDeep(

src/index.spec.js

@@ -1,4 +1,4 @@
-import EventDrops, { withinRange } from './';
+import EventDrops from './';
 import zoom from './zoom';
 
 jest.mock('./zoom');
@@ -157,29 +157,3 @@ describe('EventDrops', () => {
         jest.restoreAllMocks();
     });
 });
-
-describe('withinRange', () => {
-    it('should return true if date is in given date range', () => {
-        const dateRange = [new Date('2018-04-01'), new Date('2018-05-01')];
-        const test = (date, expectedResult) => {
-            expect(withinRange(date, dateRange)).toBe(expectedResult);
-        };
-
-        test('2018-04-19', true);
-        test('2018-04-01', true);
-        test('2018-05-01', true);
-        test('2018-05-19', false);
-    });
-
-    it('should return true if date is in given reverse date range (start date higher than end date', () => {
-        const dateRange = [new Date('2018-05-01'), new Date('2018-04-01')];
-        const test = (date, expectedResult) => {
-            expect(withinRange(date, dateRange)).toBe(expectedResult);
-        };
-
-        test('2018-04-19', true);
-        test('2018-04-01', true);
-        test('2018-05-01', true);
-        test('2018-05-19', false);
-    });
-});

src/withinRange.js

@@ -0,0 +1,7 @@
+export const withinRange = (date, dateBounds) => {
+    const startingDate = Math.min(...dateBounds);
+    const endingDate = Math.max(...dateBounds);
+
+    // @TODO: remove the `new Date()` constructor in the next major version: we need to force it at configuration level.
+    return new Date(date) >= startingDate && new Date(date) <= endingDate;
+};

src/withinRange.spec.js

@@ -0,0 +1,27 @@
+import { withinRange } from './withinRange';
+
+describe('withinRange', () => {
+    it('should return true if date is in given date range', () => {
+        const dateRange = [new Date('2018-04-01'), new Date('2018-05-01')];
+        const test = (date, expectedResult) => {
+            expect(withinRange(date, dateRange)).toBe(expectedResult);
+        };
+
+        test('2018-04-19', true);
+        test('2018-04-01', true);
+        test('2018-05-01', true);
+        test('2018-05-19', false);
+    });
+
+    it('should return true if date is in given reverse date range (start date older than end date', () => {
+        const dateRange = [new Date('2018-05-01'), new Date('2018-04-01')];
+        const test = (date, expectedResult) => {
+            expect(withinRange(date, dateRange)).toBe(expectedResult);
+        };
+
+        test('2018-04-19', true);
+        test('2018-04-01', true);
+        test('2018-05-01', true);
+        test('2018-05-19', false);
+    });
+});