[RFR] Check single row alignement

[floo51]

• Make it work
• Factorize & test

[floo51]

Ready for review

[Kmaschta]

Put a comma at each end of line

[Kmaschta]

Remove this line

[Kmaschta]

You can transform this from a function to a variable like this:

extract_chunk = tf.boolean_mask(board, mask)
is_aligned = tf.equal(tf.reduce_prod(extract_chunk), 1)

In this way:

• you avoid to recreate variables each time you use this function
• you save RAM
• you can import extract_chunk from this module too

[Kmaschta]

Consider import * is forbidden. Import each function at a time.

from reward import is_aligned

or use it directly from the module:

import reward

# Usage
reward.is_aligned

[Kmaschta]

For readability purpose, put the session run result in a variable, then check it like:
this.assertEqual(result, True)

This will help you give name to things too.

[Kmaschta]

Forbidden import *

[Kmaschta]

Most of .gitignore content is useless. KISS

[Kmaschta]

You don't have make install neither

Here is a Dockerfile that you can use for your project:

FROM python:3
ENV PYTHONUNBUFFERED 1
RUN mkdir /code
WORKDIR /code
ADD requirements.txt /code/
RUN pip install -r requirements.txt
ADD . /code/

And the related Makefile commands:

install:
    docker build -t connectfour .

run:
    docker run --rm --it -v $(shell pwd):/code connectfour python connectfour.py

test:
    docker run --rm --it -v $(shell pwd):/code connectfour python -m unittest discover

You may change some things but the most of it is here.

[floo51]

Review applied