Fix CLI host parameter short name
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ME instructions were originally not working
slax57
requested changes
Jun 7, 2023
There was a problem hiding this comment.
Thanks for your PR.
However I don't understand the change, which seems to do the opposite of what you describe.
Currently, according to my tests, the script works fine both with --port 5000 and -p 5000.
Now it might be argued that the issue is rather with the host parameter, which should be -h rather than --h, to be consistent with the other parameter and with the docs.
This is what I suggested in this review.
slax57
changed the title
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
|
Whoops, apologies for the bug in the |
slax57
changed the title
host parameter short name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, I was not able to run the JSON GraphQL server at port 5000 with-p 5000.On this branch, you can now run the the command./bin/json-graphql-server db.js -p 5000or./bin/json-graphql-server db.js --port 5000This PR fixes an inconsistency between the
--hostand--portparameters of the CLI, which short names should be-hand-prespectively. This is also what's documented in the Readme.