Update tooling #169
Merged
Update tooling #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Apr 15, 2024
|
|
||
| test: ## Launch unit tests | ||
| @NODE_ENV=test ./node_modules/.bin/jest | ||
| @NODE_ENV=test NODE_OPTIONS="$$NODE_OPTIONS --experimental-vm-modules" ./node_modules/.bin/jest |
There was a problem hiding this comment.
this I don't understand. Would you ind explaining what it does?
There was a problem hiding this comment.
Make jest accept our ESM code: https://jestjs.io/docs/ecmascript-modules
There was a problem hiding this comment.
Does that mean that, in order to use the CLI, our users will have to use the same flag? This would be a BC.
There was a problem hiding this comment.
Nope, as said in the PR desc, I tested the CLI. I did it without any flag on latest Node LTS
There was a problem hiding this comment.
The minimum required node version is 16.
adguernier
reviewed
Apr 18, 2024
djhi
commented
Apr 18, 2024
adguernier
reviewed
Apr 18, 2024
| @@ -448,15 +448,15 @@ Then use the `jsonGraphqlExpress` express middleware: | |||
|
|
|||
| ```js | |||
| import express from 'express'; | |||
| import jsonGraphqlExpress from 'json-graphql-server'; | |||
| import jsonGraphqlExpress from 'json-graphql-server/node'; | |||
There was a problem hiding this comment.
Suggested change
| import jsonGraphqlExpress from 'json-graphql-server/node'; | |
| const { default: jsonGraphqlExpress } = require("json-graphql-server/node"); |
There was a problem hiding this comment.
I reverted the change, the doc was right initially
adguernier
approved these changes
Apr 18, 2024
erwanMarmelab
approved these changes
Apr 18, 2024
fzaninotto
approved these changes
Apr 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update more dependencies
Switch to vite
Fix CLI
Check the CLI mode is working
Check the import through bundlers is working
Check the import inside Node is working