Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove any entities when you try to remove a nonexistent entity #67

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Don't remove any entities when you try to remove a nonexistent entity #67

merged 1 commit into from
Mar 22, 2019

Conversation

pjweisberg
Copy link
Contributor

This should fix the initial issue from #66, but not anything that came up in the comments, like the poor handling of string IDs.

djhi
djhi approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi merged commit d8c3bdb into marmelab:master Mar 22, 2019
@djhi djhi added this to the 2.1.4 milestone Mar 22, 2019
@Kmaschta Kmaschta modified the milestones: 2.1.4, 2.2.0 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pjweisberg @djhi @Kmaschta