Refactor as monorepo & introduce auth tools #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @djhi ! Do you have a release date in mind? |
|
Hey, I'm currently in vacation but I'll work on it in a week or so |
|
@florian-lefebvre I'd love a review if you have time :) |
Sure, I will do it! |
fzaninotto
requested changes
Aug 31, 2021
fzaninotto
requested changes
Aug 31, 2021
| throw error; | ||
| } | ||
| }, | ||
| checkError() { |
There was a problem hiding this comment.
because when one property is async, the fact that the others aren't makes me think there is a mistake. And also, the code style of each function is different, forcing me to an additional mental effort
fzaninotto
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo