Missing resources in props for Menu

[rudovjan]

What you were expecting:
Resources are passed in props to custom menu component

What happened instead:
Resources are undefined

Steps to reproduce:

const myMenu = ({ resources }) => { console.log(resources); return ''; };

return (
<Admin menu={myMeny} restClient={restClient('http://localhost:4000/api/fakeService')}>
  <Resource name="endpoint" />
</Admin>)

• Admin-on-rest version: ^1.3.2
• React version: ^15.3.0

Thank you very much,
Jan

[fzaninotto]

You need to grab the resources from the state in your custom menu, as in https://github.com/marmelab/admin-on-rest/blob/master/src/mui/layout/Menu.js#L66

[fzaninotto]

Reopening, I realize the doc is misleading on that point. It's indeed a documentation bug.

https://marmelab.com/admin-on-rest/Admin.html#menu

[rudovjan]

Thank you very much! That makes sense 💯

[alextsoi]

If I make my own menu, the compiler will throw an error.
Line 61: 'getResources' is not defined no-undef

I think it comes from the sample code in the documentation
const mapStateToProps = state => ({ resources: getResources(state), })

But I don't know how to import the correct getResources from the 'admin-on-rest' module.

[djhi]

@alextsoi please ask the question on StackOverflow

[fzaninotto]

Sorry, my mistake, I'll update the doc

[solocommand]

Is getResources actually required? It seems to work OK with the mapStateToProps removed.

Otherwise, getResources will need to be publicized: it is a named export from /reducer/index.js, and only the default export from that file is available as createAppReducer in /index.js.

[lucapette]

@fzaninotto we have just solved it as import { getResources } from "admin-on-rest/lib/reducer"; in our of our projects (thank you very much for admin-on-rest!), but to be honest I'm not so sure that's the right approach. If it is, happy to open a pr to fix the docs!