Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gist : Typescript declaration #250

Closed
pierre-H opened this issue Jan 23, 2017 · 6 comments
Closed

Gist : Typescript declaration #250

pierre-H opened this issue Jan 23, 2017 · 6 comments

Comments

@pierre-H
Copy link

Hi,
First, thank you for your work.
I created a Typescript declaration because I love Typescript and I needed Admin on Rest, so here is the declaration file : https://gist.github.com/pierre-H/5e61fdeb6e918a2108ab968a16ce4049 .

If you could add it to the official repository it would be great !

There are interfaces which are useless for end user and are helpful for declarations and I don't know how to make them private.
I am still testing it but I think it's complete.

@fzaninotto
Copy link
Member

Hi Pierre,

And thanks for your contribution!

We're not users of TypeScript, so we can't add it to the repo because it would get out of date pretty quickly. I don't know if parsers have the option to accept a path for declarations, in which case you could publish these types in a third-party repository?

@djhi
Copy link
Contributor

djhi commented Jan 26, 2017

https://github.com/typings/typings ?

@hubert-associates
Copy link

The contributor above is offering to increase the quality of your interesting admin page by adding typings ... and you are not interested? Such typings make the difference between professional quality and "risky business" these days: reactjs has typings, angular has typings, apollo has typings, marmalab has "we don't use"? Please reconsider involving the contribution above.

@djhi
Copy link
Contributor

djhi commented Jan 17, 2018

That's not what @fzaninotto answered. As we are do not use TypeScript, we will not be able to keep the typings in sync with the project. We'd rather have those typings in userland, at least for now, than have countless issues about deprecated ones in our repository.

@hubert-associates
Copy link

hubert-associates commented Jan 17, 2018

In javascript, any typing is better than no typing.

Out of the box:
Uncaught TypeError: (0 , _aorGraphqlClient.buildApolloClient) is not a function
at exports.default (bundle.js:129824)
at App.componentWillMount (bundle.js:33562)
at bundle.js:27173
at measureLifeCyclePerf (bundle.js:26900)
at ReactCompositeComponentWrapper.performInitialMount (bundle.js:27172)
at ReactCompositeComponentWrapper.mountComponent (bundle.js:27083)
at Object.mountComponent (bundle.js:18809)
at ReactCompositeComponentWrapper.performInitialMount (bundle.js:27196)
at ReactCompositeComponentWrapper.mountComponent (bundle.js:27083)
at Object.mountComponent (bundle.js:18809)

@Vadorequest
Copy link

Vadorequest commented Mar 6, 2020

Discussion regarding TS has moved to #1617 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants