Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing "dense={false}" to a custom Menu does not affect the dashboard MenuItem #4296

Closed
guilleironhack opened this issue Jan 15, 2020 · 2 comments
Labels

Comments

@guilleironhack
Copy link

What you were expecting:
When creating a custom Menu with prop dense={false}, I expect all the menu elements not to have the dense properties

What happened instead:
The dense prop is not passed to the DashboardMenuItem and therefore it's not affected

Steps to reproduce:

  • Add a Dashboard to an app
  • Create a custom Menu with dense={false}
  • Add the custom Menu to the Layout

Related code:
https://codesandbox.io/s/mystifying-stallman-e8brq

Other information:

Environment

  • React-admin version: v3.1.2
  • React version: 16.9.0
  • Browser: Chrome 79.0.3945.117
@djhi
Copy link
Contributor

djhi commented Jan 15, 2020

Reproduced on the codesandbox. Thanks! This is weird though, it should have been fixed by #4241

@djhi djhi added the bug label Jan 15, 2020
@djhi djhi added this to the 3.2.0 milestone Jan 23, 2020
@djhi
Copy link
Contributor

djhi commented Jan 23, 2020

Just noticed that #4241 was merged on next so this is fixed but will only be available in 3.2.0

@djhi djhi closed this as completed Jan 23, 2020
@fzaninotto fzaninotto removed this from the 3.2.0 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants