[RFR] Also pass the dense prop from the Menu to the DashboardMenuItem #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led the same as the reguler menu items
djhi
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When I was applying custom styling to the sidebar menu, I noticed that the
Dashboardmenu item didn't always have the same styling as the other menu items.Cause
When looking in detail, I discovered that the regular menu items dynamically get a
densevalue set, but that theDashboardMenuItemdoesn't get this value. Besides that it configures thedenseprop to always be true.Changes described
I modified the
DashboardMenuItemso it doesn't configure thedenseprop itself, but it instead relies on the props passed. I changed theMenuso it passes thedenseprop to theDashboardMenuItemjust like it does for the other menu items.