validateResponseFormat triggers error when calling a dataProvider custom method

[jvert]

If you implement a data provider with a custom method, then call that method as documented here then validateResponseFormat() throws an error if the returned object doesn't contain a 'data' key

The response to 'action' must be like { data: ... }, but the received response does not have a 'data' key. The dataProvider is probably wrong for 'action'.

I think if it's a custom method, there should not be any validation of the returned object (how could react-admin know?)

Otherwise, maybe the type of DataProvider should be typed better than [key: string]: any

[antoinefricker]

Thanks for your pertinent report.

IMHO, validateResponseFormat() should be perfectly un-opinionated about custom methods and we should harmonize the documentation and types accordingly. Change would not introduce breaking changes as it lower data requirements.

Feedback on this topic will be very gladly welcomed!

[fzaninotto]

I agree, validateResponseFormat should only be called on the dataProvider methods documented there:

https://marmelab.com/react-admin/DataProviderWriting.html#request-format

I'm marking this as an enhancement. Feel free to open a PR to implement it.

[ogustavo-pereira]

I can try to help with this update

[fzaninotto]

Sure, please do!

[fzaninotto]

Fixed by #8159