Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Document components using Docz #1939

Closed
wants to merge 11 commits into from
Closed

[WIP] Document components using Docz #1939

wants to merge 11 commits into from

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jun 20, 2018

Testing Docz for API doc generation.

  • Make docz work
  • Document a few components
  • Tweak publish script to generate components doc alongside the existing doc

I'm not convinced that docz is finished. Some of the basic requirements aren't yet met, so I'll put this issue on pause until docz matures a bit.

localhost_3000_packages-ra-ui-materialui-src-button-edit-button 2

@djhi
Copy link
Contributor

djhi commented Jun 21, 2018

Some of the basic requirements aren't yet met

Can you elaborate ?

@fzaninotto
Copy link
Member Author

fzaninotto commented Jun 21, 2018

Out the top of my head:

Remove Playground
@ashim-kr-saha
Copy link
Contributor

Definitely, we will get so much help with this kind of documentation. In the above example, I got some more clarity. +1

@fzaninotto fzaninotto added this to the 2.3.0 milestone Aug 1, 2018
@fzaninotto fzaninotto modified the milestones: 2.3.0, v2.4.0 Sep 7, 2018
@fzaninotto fzaninotto modified the milestones: 2.4.0, 2.5.0 Oct 17, 2018
@fzaninotto fzaninotto removed this from the 2.5.0 milestone Nov 30, 2018
@brikou
Copy link

brikou commented Dec 14, 2018

TS support with Docz is quite good, and automated Props table works as expected (default export is not required anymore, IProps signature is well parsed, just as Cmpt.defaultProps). You should give another try with newly converted TS components.

@fzaninotto
Copy link
Member Author

The problem is we already have to migrate all ra-core to TypeScript to be able to migrate components. Wanna give us a hand?

@brikou
Copy link

brikou commented Dec 14, 2018

@fzaninotto why not, I can work on a few files. I'll take a look this week-end 👍

@brikou
Copy link

brikou commented Dec 15, 2018

After playing with Docz, I don't thing this is the right tool to build a robust documentation.
Why? Because of MDX and lack of TS support. Documentation cannot be checked by TS.

@fzaninotto
Copy link
Member Author

This Pr is too old. If we ever generate API doc, we'll give Docz another try.

@fzaninotto fzaninotto closed this Sep 17, 2019
@fzaninotto fzaninotto deleted the docz branch September 17, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants