Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Simplify ListView to allow easier override #2028

Merged
merged 4 commits into from Jul 18, 2018
Merged

[RFR] Simplify ListView to allow easier override #2028

merged 4 commits into from Jul 18, 2018

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jul 18, 2018 •
edited

  • Expose setPerPage() in List
  • ListView should inject the same props to all its children (actions, list, and pagination)
  • Expose omit and pick for ListController props to allow easier override

Supersedes parts of #1923

@fzaninotto fzaninotto changed the title [RFR] Simplify ListView to allow easier override [WIP] Simplify ListView to allow easier override Jul 18, 2018
@djhi
Copy link
Contributor

djhi commented Jul 18, 2018

Prettier issues. Looks good otherwise 👍

@fzaninotto fzaninotto changed the title [WIP] Simplify ListView to allow easier override [RFR] Simplify ListView to allow easier override Jul 18, 2018
@djhi djhi added this to the 2.2.0 milestone Jul 18, 2018
@djhi djhi merged commit ce6b4a5 into next Jul 18, 2018
@fzaninotto fzaninotto mentioned this pull request Jul 18, 2018
Closed
12 tasks
@djhi djhi deleted the list_components branch July 18, 2018 10:37
This was referenced Jul 18, 2018
Merged
Closed
@fzaninotto fzaninotto mentioned this pull request Jul 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fzaninotto @djhi