Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] ·Add documentation on the data returned from create requests #2262

Merged
merged 1 commit into from Sep 19, 2018

Conversation

cuococarlos
Copy link

closes #2087

@cuococarlos cuococarlos changed the title [WIP] ·Changes the data returned from create requests [RFR] ·Changes the data returned from create requests Aug 31, 2018
@djhi
Copy link
Contributor

djhi commented Sep 1, 2018

Thank you for contributing! However, as @fzaninotto said in the linked issue (#2087), we don't want to make this change now as it will be a breaking one and it is easy to implement your own data provider.

I apologize as my last comment on this issue missed the word documentation. Indeed, we only want to make those data providers behavior regarding CREATE clearer. I updated this comment accordingly

@cuococarlos
Copy link
Author

Ok.Tomorrow, i will write documentation in another pr and close this.

@cuococarlos cuococarlos changed the title [RFR] ·Changes the data returned from create requests [WIP] ·Add documentation on the data returned from create requests Sep 4, 2018
@cuococarlos
Copy link
Author

I added the documentation on this topic. but I do not know if it will be necessary to add it in another document too

@cuococarlos cuococarlos changed the title [WIP] ·Add documentation on the data returned from create requests [RFR] ·Add documentation on the data returned from create requests Sep 4, 2018
@fzaninotto fzaninotto added this to the 2.4.0 milestone Sep 19, 2018
@fzaninotto fzaninotto merged commit 8dcd1e2 into marmelab:next Sep 19, 2018
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants