Fix Edit toolbar hides the last form item on mobile #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making bottom padding for last child to be 70px for xs media size
djhi
requested changes
Oct 24, 2018
| }; | ||
| '&:last-child': { | ||
| paddingBottom: 16, | ||
| // Reset on mouse devices |
There was a problem hiding this comment.
Can you remove this comment? It does not bring anything as the code is clear enough
There was a problem hiding this comment.
I'd still like a screenshot please :)
|
@djhi screenshot of before and after? |
|
|
djhi
approved these changes
Oct 24, 2018
|
Thanks! I'll wait for @fzaninotto review though |
|
There is something wrong with your screenshot: the action buttons should not appear above the Save button. Is is a side effect of your change? |
|
@fzaninotto this is just my custom form control from Advanced Tutorials |
|
just see what is going on on mobile view without custom controls... it is broken |
fzaninotto
changed the title
fzaninotto
approved these changes
Oct 25, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making bottom padding for last child to be 70px for xs media size
Fix #2463