Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disabled option in SelectInput #2555

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Add disabled option in SelectInput #2555

merged 2 commits into from
Nov 22, 2018

Conversation

mikaoelitiana
Copy link
Contributor

fixes #2512

@mikaoelitiana
Use disabled option in SelectInput choices
91fbb21 
- choices with a `disabled: true` property are disabled
- property name can be set with `disableValue`
@mikaoelitiana
add unit testing
0b0aef0
@mikaoelitiana
Copy link
Contributor Author

mikaoelitiana commented Nov 22, 2018 •
edited by fzaninotto
Loading

@fzaninotto this is the replacement for #2539

@fzaninotto fzaninotto merged commit 1da1d92 into marmelab:next Nov 22, 2018
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 2.5.0 milestone Nov 22, 2018
@fzaninotto fzaninotto mentioned this pull request Nov 22, 2018
Closed
fzaninotto added a commit that referenced this pull request Dec 3, 2018
@fzaninotto
Fix warning in SelectInput test
02962ac 
Refs #2555
@fzaninotto fzaninotto mentioned this pull request Dec 3, 2018
Merged
@maxmalov maxmalov mentioned this pull request Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikaoelitiana @fzaninotto