[RFR] Add ability to attach an expansion panel to a datagrid row #2634
Conversation
Supports Edit and Show components as expand
fzaninotto
changed the title
|
|
||
| describe('expand panel', () => { | ||
| it('should show an expand button opening the expand element', () => { | ||
| cy.contains('1-10 of 13'); // wait for data |
There was a problem hiding this comment.
You should add an expectation here: .should(el => expect(el).to.exist)
There was a problem hiding this comment.
I don't want to do an assertion here, just wait. Also, the other tests in this file don't do that either.
There was a problem hiding this comment.
I used to do that too but @Kmaschta pointed out that this is actually not blocking without assertions
There was a problem hiding this comment.
I've done some reading.
The Cypress docs says you're wrong:
https://docs.cypress.io/guides/core-concepts/introduction-to-cypress.html#For-instance
Core Concept
All DOM based commands automatically wait for their elements to exist in the DOM.
You never need to write .should('exist') after a DOM based command.
And it repeats it:
https://docs.cypress.io/guides/references/best-practices.html#Unnecessary-wait-for-cy-get
And it repeats it again:
https://docs.cypress.io/guides/core-concepts/introduction-to-cypress.html#Commands-Are-Asynchronous
I only found one person saying what you say:
I am very unsure that you're right. If you can reproduce the contains not waiting before executing the next cypress command behavior, I suggest you open an issue in the Cypress bug tracker, because that's a bug of theirs.
Until then, I'll assume Cypress does what their doc says.
cypress/integration/list.js
Outdated
| cy.get('[role="expand"]') | ||
| .eq(0) | ||
| .click(); | ||
| cy.get('[role="expand-content"]').should( |
There was a problem hiding this comment.
I avoid magic strings expectations as they prevent tools such as the IDE autocompletion and type checking to do their job. I suggest to use the following form: .should(el => expect(el).to.contain(''))
cypress/integration/list.js
Outdated
| 'contain', | ||
| 'Curabitur eu odio ullamcorper, pretium sem at, blandit libero. Nulla sodales facilisis libero, eu gravida tellus ultrices nec. In ut gravida mi. Vivamus finibus tortor tempus egestas lacinia. Cras eu arcu nisl. Donec pretium dolor ipsum, eget feugiat urna iaculis ut.' | ||
| ); | ||
| cy.get('.datagrid-body').should( |
cypress/integration/list.js
Outdated
| cy.get('[role="expand"]') | ||
| .eq(1) | ||
| .click(); | ||
| cy.get('[role="expand-content"]').should('have.length', 2); |
| }); | ||
|
|
||
| it('should accept multiple expands', () => { | ||
| cy.contains('1-10 of 13'); // wait for data |
There was a problem hiding this comment.
Same as above, it's just a wait
expandprop to<Datagrid>