Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ra-data-graphql-simple: Fix filter id applied incorrectly to get many ref #2649

Merged
merged 2 commits into from
Apr 15, 2019
Merged

ra-data-graphql-simple: Fix filter id applied incorrectly to get many ref #2649

merged 2 commits into from
Apr 15, 2019

Conversation

kenanwarren
Copy link
Contributor

Fixes issue #2571

@fzaninotto fzaninotto changed the title Fix filter id applied incorrectly to get many ref ra-data-graphql-simple: Fix filter id applied incorrectly to get many ref Dec 11, 2018
@kenanwarren
Copy link
Contributor Author

I'll check the failing tests when I get home.

@kenanwarren
Copy link
Contributor Author

Alright after looking through the rest of the code in this area it makes sense. Not sure how the code in that issue worked for the OP though. I amended the commit with something similar to what I'm doing in my workaround, let me know if I need to update anything else.

@fzaninotto fzaninotto requested a review from djhi December 12, 2018 06:30
@kenanwarren kenanwarren deleted the patch-1 branch December 21, 2018 19:43
@christiaanwesterbeek
Copy link
Contributor

I encountered the same problem and fixed it according to this PR. I vote to re-open and merge this PR.

@christiaanwesterbeek christiaanwesterbeek mentioned this pull request Apr 12, 2019
Closed
@djhi
Copy link
Contributor

djhi commented Apr 12, 2019

I don't know why @redorb closed this PR

@kenanwarren kenanwarren restored the patch-1 branch April 15, 2019 02:08
@kenanwarren
Copy link
Contributor Author

I can't remember why I ended up closing it. Feel free to look through the PR if it's still in need of a fix.

@kenanwarren kenanwarren reopened this Apr 15, 2019
@kenanwarren
Copy link
Contributor Author

Merged master into the branch, sorry if anything is weird. I'm doing these edits in the github UI since I'm not going to be near my laptop for a month or so.

djhi
djhi approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 2.8.6 milestone Apr 15, 2019
@djhi djhi merged commit 99960f8 into marmelab:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenanwarren @christiaanwesterbeek @djhi