-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix <RichTextInput> not working on IE11 #2676
Conversation
Are you sure this change doesn't affect the display of the component? |
@Kmaschta My guess is that since the property is considered as invalid in Chrome (see screenshot), it currently has no effect on the display. I can however try and screenshot multiple situations in Chrome and see if each of them works in IE11:
I may have some time today, otherwise tomorrow |
Nvm you're right, if it doesn't work on Chrome and it breaks IE, this make no sense to keep it. |
The empty content was added in aad754a, probably for a good reason. Removing the |
@fzaninotto Good catch! I’ll do a more thorough review of any impacts (and/or try to set the content to |
Fixes marmelab#2675 The underlying problem is in the [css-vendor](https://github.com/cssinjs/css-vendor) library, specifically in the cssVendor.supportedValue method that breaks on IE11 with content and '' as parameters. the `content: ''` attribute is currently not working on Chrome either.
@fzaninotto Hi, and happy new year 🥳 Found a way better approach to solving this: as per cssinjs/jss#866 (JSS is a dependency of MaterialUI), the property To translate the proper CSS Works like a charm now! However, there still is an issue on the layout (long text requires horizontal scrolling), which I’ll try to fix in a future PR (see screenshot): Thanks! |
Thanks! |
Fixes #2675
The underlying problem is in the css-vendor library, specifically in the cssVendor.supportedValue method that breaks on IE11 with content and '' as parameters.
the
content: ''
attribute is currently not working on Chrome either.