Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct consecutive get() in cypress instruction #2712 #2713

Merged
merged 3 commits into from
Jan 3, 2019
Merged

Correct consecutive get() in cypress instruction #2712 #2713

merged 3 commits into from
Jan 3, 2019

Conversation

JacquesBonet
Copy link
Contributor

  • Create a new svg access function permitting to acces the right element.
  • correct another problem about headroom css class. This class doesn't exist with a production build using react-script, so use alternative css class.

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it seems better indeed

@@ -3,6 +3,7 @@
"name": "e2e",
"version": "0.1.0",
"scripts": {
"serve": "node ./infinitStart.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed ? Looks irrelevant to this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It permits to test simple application interactively. Under cypress, launch a terminal and start
:> yarn serve
launch another terminal and start:
:> yarn start

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its quite irrelevant to this PR. I agrea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference with:

launch a terminal and start make run-simple

launch another terminal and start make test-e2e-local

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My solution permits just to launch cypress tests from cypress directory, like the overall test.
Its not important, you can remove it if you like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you aware of the npm commands inside the root package.json. If you can't use make, you can:

launch a terminal and start yarn run-simple

launch another terminal and start yarn test-e2e-local

Can you remove the new ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 2.6.0 milestone Jan 3, 2019
@djhi djhi merged commit c77e0e0 into marmelab:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants