Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix warning when disabling a button on small devices #2731

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

Luwangel
Copy link
Contributor

@Luwangel Luwangel commented Jan 7, 2019

With Material UI, it is not possible to wrap a disabled IconButton inside a Tooltip.

<Tooltip title={translate(label, { _: label })}>
    <IconButton
        aria-label={translate(label, { _: label })}
        color={color}
        disabled // This is not allowed
    >
        {children}
    </IconButton>
</Tooltip>

The PR #2595 causes this issue when there are not data to export.

Todo

  • Don't display the Tooltip on small devices when the IconButton is disabled

peek 07-01-2019 10-12

@fzaninotto fzaninotto merged commit 302a1a1 into next Jan 7, 2019
@fzaninotto fzaninotto deleted the fix-disabled-button-warning branch January 7, 2019 09:43
@fzaninotto fzaninotto added this to the 2.6.0 milestone Jan 7, 2019
@fzaninotto fzaninotto removed the bug label Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants