[RFR] BooleanField accessibility #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Jan 10, 2019
| {...sanitizeRestProps(rest)} | ||
| > | ||
| <span className={classes.label}>{ariaLabel}</span> |
There was a problem hiding this comment.
why do we need this span since we have an aria-label?
There was a problem hiding this comment.
I must say I'm not sure about the best practices here. I think label elements should only be used with interactive elements such as inputs or buttons. It made sense for me that it was true for aria-label attributes: https://w3c.github.io/using-aria/#label-support
There was a problem hiding this comment.
I removed the aria-label attribute
fzaninotto
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way for a screen reader or an e2e test to know what's the field value as it only contains an icon.