Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore Data Provider #2778

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Firestore Data Provider #2778

merged 2 commits into from
Jan 22, 2019

Conversation

rafalzawadzki
Copy link
Contributor

Added a third-party repository supporting the Firestore database.

Added a third-party repository supporting the Firestore database.
@fzaninotto
Copy link
Member

There is already a third-party Firebase provider, what's different in this one? Why didn't you contribute these differences to the original library?

@rafalzawadzki
Copy link
Contributor Author

Hello @fzaninotto, the existing Firebase provider supports only Realtime Database and not its successor, Cloud Firestore. There are major differences in data structure, querying, SDKs etc between these two and it does not make sense to build one provider to cater to both of them.

@fzaninotto
Copy link
Member

Then please update the first link to point to https://firebase.google.com/docs/firestore/ rather than to your plugin repository

@fzaninotto fzaninotto added this to the 2.6.3 milestone Jan 21, 2019
Links point to respective documentation
@rafalzawadzki
Copy link
Contributor Author

Committed changes of both Firebase & Firestore doc links for clarity 👍

@fzaninotto fzaninotto merged commit 748d10e into marmelab:master Jan 22, 2019
@fzaninotto
Copy link
Member

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants